Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong fonts being used when font-lock-mode is enabled #106

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

ubolonton
Copy link
Contributor

font-lock+ was removed, so font-lock-ignore no longer works.

font-lock-fix

`font-lock+` was removed, so `font-lock-ignore` no longer works.
@stardiviner
Copy link
Contributor

Really fast patch. Great!

@zhengpd
Copy link

zhengpd commented Feb 28, 2018

This change works for me.

@wyuenho
Copy link
Collaborator

wyuenho commented Jun 19, 2018

@domtronn This is a perfectly good patch. Can it be merged?

@cnngimenez
Copy link

I did the modifications manually and it works. 😃

@domtronn This is a perfectly good patch. Can it be merged?

The line numbers of the patch matches with the current master version. So it shouldn't be a problem to merge.

Please, can you merge this pull request so @melpa can have this patch? 🙏

Thanks!

@Silex
Copy link

Silex commented Aug 12, 2018

@ubolonton: can you rebase so it's easy to merge?
@domtronn: can you merge this? it's annoying that it almost works out of the box but doesn't

@montaropdf
Copy link

Hi,

What is the status of this bug?

When is it planned to have an updated version of the package via MELPA?

@stardiviner
Copy link
Contributor

Still no progress on this PR. What about using a fork?

@benbot
Copy link

benbot commented Jan 23, 2019

This PR has almost been open for a year. Any chance of it going in soon?

@wyuenho
Copy link
Collaborator

wyuenho commented Jan 23, 2019

Somebody please fork this repo, change its name and submit PRs to all the packages on Melpa that's currently using all-the-icons to [your-new-repo]. I've emailed the author like 10 times, at once he promised to add me as a maintainer but it's been ages since then.

takaxp added a commit to takaxp/all-the-icons.el that referenced this pull request Feb 4, 2019
@pstray
Copy link

pstray commented Feb 6, 2019

Not sure why, but this patch does not work for me... inserting icons into a buffer without font-lock works, but turning on font-lock breaks all the icons.

@wyuenho wyuenho merged commit 5fd1c0b into domtronn:master Feb 15, 2019
@stardiviner
Copy link
Contributor

Aow, finally merged, thanks @wyuenho

@jmromer
Copy link

jmromer commented Feb 16, 2019

screen shot 2019-02-15 at 11 41 02 pm

busted-icons

screen shot 2019-02-16 at 12 26 51 am

Still seeing this on master, fwiw. Investigating.

Update: Partially fixed by updating the material design icon set as suggested in
#35 (comment)

screen shot 2019-02-16 at 12 33 06 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants